Remove Disable accent characters for menus that it's not needed on #372 #375
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and iOS rooms once you're in. It'd be great to have you! Maintainer checklist
|
henrikth93
changed the title
| let accentKeyLanguages: [String] = ["Swedish", "German", "Spanish"]; //Languages where we can disable accent keys | ||
| if (accentKeyLanguages.firstIndex(of: section.sectionTitle) == nil) | ||
| { | ||
| SettingsTableData.languageSettingsData[0].section.remove(at: 1) //If there are no accent keys we remove the option. |
There was a problem hiding this comment.
This is really great, @henrikth93! Could we add one line right before this that checks what the the index is for Disable accent characters and then we can drop that index specifically? As of now if something else goes in at index 1 this will break its functionality :)
Aside from this, 100% what we're looking for! 😊
There was a problem hiding this comment.
Sure! That is a good idea! I will change that asap! :)
There was a problem hiding this comment.
Thanks @henrikth93! Will merge it in soon after 🤠
There was a problem hiding this comment.
I see what you mean by hacky, @henrikth93 🙃 Looks good though! I'll bring it in and see if I can do something to get rid of the need to do the -1 option :) Will update in the issue if I can figure something out!
Contributor checklist
Description
Related issue